-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add lint and format check #208
ci: add lint and format check #208
Conversation
✅ Deploy Preview for valibot canceled.
|
Thank you! This is great! I think it makes sense to do the format and lint checks before the tests. What do you think about that? Or is it better to run each check independently in its own pipeline? Do you know how other projects do this? |
@fabian-hiller
Yes, I think so too, because the format and lint checks don’t usually take so much time, therefore there is a slight time difference between running all in series and running each check in parallel.
Here are some examples:
|
Right now I think it's best to run everything in parallel and list each check individually on a PR so you know exactly what doesn't fit. What do you think? |
Thank you for your work. I think something is not configured properly yet. At least not all the checks are running yet. |
Did you configure that the job |
Thank you for your quick response! |
Fixed! 😄
I think both are acceptable now, but in the long term, running everything in parallel will be better, because of the expectation of the increase of CI check, which causes delay. |
Thank you for your contribution! I will review your changes in the next 24 hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for improving this. I find this very useful for all future PRs. The code looks good. I just want to rename a few labels. Once I have done that, I will merge the PR.
Thank you for your words! 😄
OK, go ahead! |
57a013d
to
65bc232
Compare
d6d70c8
to
bc205cb
Compare
bc205cb
to
66be71d
Compare
Since the number of implemented linter rules is increasing (#205 #202) and will be increased very much, I added lint (and format) check to CI.
This will reduce the review time and effort 😄